Skip to content

[ISSUE #8094]♻️Show unified telemetry bootstrap in examples#8095

Merged
mxsm merged 1 commit into
mainfrom
mxsm/logging-bootstrap-examples
Jul 6, 2026
Merged

[ISSUE #8094]♻️Show unified telemetry bootstrap in examples#8095
mxsm merged 1 commit into
mainfrom
mxsm/logging-bootstrap-examples

Conversation

@mxsm

@mxsm mxsm commented Jul 6, 2026

Copy link
Copy Markdown
Owner

Which Issue(s) This PR Fixes(Closes)

Brief Description

This PR updates selected examples to demonstrate the unified telemetry logging bootstrap instead of direct subscriber setup or compatibility logger helpers.

Changes include:

  • Add rocketmq-observability/examples/logging_bootstrap.rs as a minimal TelemetryBootstrapConfig and install_global example.
  • Update the simple producer example to hold TelemetryRuntimeGuard until completion and shut it down explicitly.
  • Update the send callback producer example to use the unified bootstrap before emitting tracing events.
  • Update the controller single-node example to use the unified bootstrap while preserving stdout example output.
  • Keep documentation files untouched per repository workflow for this refactor slice.

How Did You Test This Change?

  • cargo fmt --all passed.
  • cargo test -p rocketmq-observability --examples --all-features passed.
  • cargo test -p rocketmq-client-rust --examples --all-features passed.
  • cargo test -p rocketmq-controller --examples --all-features passed.
  • cargo clippy --workspace --no-deps --all-targets --all-features -- -D warnings passed.

@mxsm mxsm merged commit e799062 into main Jul 6, 2026
7 of 8 checks passed
@mxsm mxsm deleted the mxsm/logging-bootstrap-examples branch July 6, 2026 17:46
@coderabbitai

coderabbitai Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@mxsm, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 8 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 9db5e3c6-c209-43e9-a424-87be9390f101

📥 Commits

Reviewing files that changed from the base of the PR and between 850c382 and 3c4eecc.

📒 Files selected for processing (4)
  • rocketmq-client/examples/producer/send_callback_examples.rs
  • rocketmq-client/examples/producer/simple_producer.rs
  • rocketmq-controller/examples/single_node.rs
  • rocketmq-observability/examples/logging_bootstrap.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch mxsm/logging-bootstrap-examples

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@rocketmq-rust-robot rocketmq-rust-robot added the refactor♻️ refactor code label Jul 6, 2026
@rocketmq-rust-bot

rocketmq-rust-bot commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator

🔊@mxsm 🚀Thanks for your contribution🎉！

💡CodeRabbit(AI) will review your code first🔥！

Note

🚨The code review suggestions from CodeRabbit are to be used as a reference only, and the PR submitter can decide whether to make changes based on their own judgment. Ultimately, the project management personnel will conduct the final code review💥.

@rocketmq-rust-bot rocketmq-rust-bot added AI review first Ai review pr first auto merge ready to review waiting-review waiting review this PR approved PR has approved and removed ready to review waiting-review waiting review this PR labels Jul 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rocketmq-rust-bot rocketmq-rust-bot Awaiting requested review from rocketmq-rust-bot
@SpaceXCN SpaceXCN Awaiting requested review from SpaceXCN
@TeslaRustor TeslaRustor Awaiting requested review from TeslaRustor

Assignees

No one assigned

Labels

AI review first Ai review pr first approved PR has approved auto merge refactor♻️ refactor code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Refactor♻️] Show unified telemetry bootstrap in examples

3 participants

@mxsm @rocketmq-rust-bot @rocketmq-rust-robot